[PATCH] D151280: [NFC][CLANG] Fix static code analyzer concerns

2023-05-25 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc3e7c6e9e080: [NFC][CLANG] Fix static code analyzer concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151280/new/

[PATCH] D151280: [NFC][CLANG] Fix static code analyzer concerns

2023-05-24 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 525388. Manna added a comment. Thank you @erichkeane for reviews! I have updated assert message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151280/new/ https://reviews.llvm.org/D151280 Files: clang/lib/CodeGen/CGExprConstant.cpp Index:

[PATCH] D151280: [NFC][CLANG] Fix static code analyzer concerns

2023-05-24 Thread Erich Keane via Phabricator via cfe-commits
erichkeane requested changes to this revision. erichkeane added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1343 const ConstantArrayType *CAT = CGM.getContext().getAsConstantArrayType(T); +assert(CAT

[PATCH] D151280: [NFC][CLANG] Fix static code analyzer concerns

2023-05-23 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Reported by Static