evelez7 abandoned this revision.
evelez7 added inline comments.
Comment at: clang/include/clang/ExtractAPI/Serialization/SerializerBase.h:28-31
+struct APISetVisitorOption {
/// Do not include unnecessary whitespaces to save space.
bool Compact;
};
dang
evelez7 updated this revision to Diff 525652.
evelez7 added a comment.
Really address review feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151293/new/
https://reviews.llvm.org/D151293
Files:
evelez7 updated this revision to Diff 525431.
evelez7 marked 8 inline comments as done.
evelez7 added a comment.
Address some review feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151293/new/
https://reviews.llvm.org/D151293
Files:
dang requested changes to this revision.
dang added a comment.
This revision now requires changes to proceed.
Great start but there are still some rough edges to polish!
Comment at: clang/include/clang/ExtractAPI/Serialization/SerializerBase.h:19
#include
evelez7 created this revision.
Herald added a reviewer: ributzka.
Herald added a project: All.
evelez7 requested review of this revision.
Herald added a reviewer: dang.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Refactor SerializerBase and SymbolGraphSerializer to use
