[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-06-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/D151320 ___ cfe-commits mailing list cfe-comm

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-27 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny accepted this revision. jdenny added inline comments. Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = VerifyDiagnosticConsumer::HasExpectedMaybeNoDiagnostics; + continue; +} else if (DToken.endswith(DType="-no-diagnostics")) { ---

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-27 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added inline comments. Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = VerifyDiagnosticConsumer::HasExpectedMaybeNoDiagnostics; + continue; +} else if (DToken.endswith(DType="-no-diagnostics")) { jdenny wrote: > E

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-27 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill updated this revision to Diff 526277. Endill added a comment. Replace A2 test with E1-E3 tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/D151320 Files: clang/include/clang/Basic/DiagnosticFrontendK

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-27 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added inline comments. Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = VerifyDiagnosticConsumer::HasExpectedMaybeNoDiagnostics; + continue; +} else if (DToken.endswith(DType="-no-diagnostics")) { Endill wrote: > j

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-26 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added a comment. Thank you for your time! Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = VerifyDiagnosticConsumer::HasExpectedMaybeNoDiagnostics; + continue; +} else if (DToken.endswith(DType="-no-diagnostics")) { -

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-26 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land. Thanks for addressing all my concerns. LGTM except for a test issue I just commented on. Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = Ve

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-26 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added inline comments. Comment at: clang/include/clang/Frontend/VerifyDiagnosticConsumer.h:186-202 +/// Additionally, you can use: +/// +/// \code +/// // expected-maybe-no-diagnostics +/// \endcode +/// +/// to specify that a file with no "expected-*" comments should pa

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-26 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill updated this revision to Diff 526101. Endill added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/D151320 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-26 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added inline comments. Comment at: clang/include/clang/Frontend/VerifyDiagnosticConsumer.h:186-202 +/// Additionally, you can use: +/// +/// \code +/// // expected-maybe-no-diagnostics +/// \endcode +/// +/// to specify that a file with no "expected-*" comments should pa

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-26 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added a comment. Thank you for the review! Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:468 +Status = VerifyDiagnosticConsumer::HasExpectedMaybeNoDiagnostics; + continue; +} else if (DToken.endswith(DType="-no-diagnostics")) {

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-26 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill updated this revision to Diff 526013. Endill edited the summary of this revision. Endill added a comment. Address feedback Docs contributed by @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-25 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. Thanks for working on this. I've been wanting something like it too. In downstream work, I've used a hack that seems to accomplish the same thing but probably shouldn't: `expected-error 0 {{}}`. Anyway, please add documentation for the new directive here: https://clan

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-24 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill marked an inline comment as done. Endill added a comment. Thank for for providing a nice explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/D151320 ___

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-24 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill updated this revision to Diff 525216. Endill added a comment. Add missing comma after enum item Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151320/new/ https://reviews.llvm.org/D151320 Files: clang/include/clang/Frontend/VerifyDiagnosti

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. > This patch introduces a `// expected-maybe-not-diagnostic` that silence typo in the summary, it introduces `// expected-maybe-no-diagnostics` To save other reviewers some clicking around, the reason why this is being proposed is because we want to use the `split

[PATCH] D151320: [clang] Add `// expected-maybe-no-diagnostics` comment to VerifyDiagnosticConsumer

2023-05-24 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill created this revision. Endill added reviewers: aaron.ballman, hfinkel, dblaikie. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch introduces a `// expected-maybe-not-diagnostic` that sile