[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5df593a35471: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method (authored by HerrCai0907). Repository: rG LLVM Github M

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151365/new/ https://reviews.llvm.org/D151365 __

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 updated this revision to Diff 525754. HerrCai0907 added a comment. remove not related change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151365/new/ https://reviews.llvm.org/D151365 Files: clang/docs/ReleaseNotes.rst clang/lib/Se

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 updated this revision to Diff 525752. HerrCai0907 added a comment. avoid desurger Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151365/new/ https://reviews.llvm.org/D151365 Files: clang/docs/ReleaseNotes.rst clang/lib/Basic/Targets

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:968 +.getNonReferenceType() +->getLocallyUnqualifiedSingleStepDesugaredType(); Diags.Report(Active->PointOfInstantiation, This doesn'

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:969 << (int)DFK.asComparison() -<< Context.getTagDeclType( - cast(FD->getLexicalDeclContext())); +<< Context.getRecordType(RecordType->

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 updated this revision to Diff 525718. HerrCai0907 added a comment. Herald added subscribers: pmatos, asb, aheejin, jgravelle-google, sbc100, dschuff. getLocallyUnqualifiedSingleStepDesugaredType to find the whole record name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:969 << (int)DFK.asComparison() -<< Context.getTagDeclType( - cast(FD->getLexicalDeclContext())); +<< Context.getRecordType(RecordType->g

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 updated this revision to Diff 525452. HerrCai0907 added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151365/new/ https://reviews.llvm.org/D151365 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemplateInst

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 updated this revision to Diff 525333. HerrCai0907 added a comment. change solution Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151365/new/ https://reviews.llvm.org/D151365 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTem

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

erichkeane added a comment. In D151365#4369650 , @HerrCai0907 wrote: > In D151365#4369605 , @erichkeane > wrote: > >> As Richard says, we should just be taking the first parameter type and using >> that instead

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

HerrCai0907 added a comment. In D151365#4369605 , @erichkeane wrote: > As Richard says, we should just be taking the first parameter type and using > that instead (obviously de-qualified and removing reference if necessary). But we still can find the c

[PATCH] D151365: [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

erichkeane added a comment. As Richard says, we should just be taking the first parameter type and using that instead (obviously de-qualified and removing reference if necessary). Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:964 } else if (DFK.isComparison())