[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

2023-07-25 Thread Fridtjof Mund via Phabricator via cfe-commits
fridtjof updated this revision to Diff 544142. fridtjof added a comment. I fixed the failing IBOutletCollection.m test - there was code to do special handling for the respective attribute type, which my patch accidentally skipped previously. I reordered the generic attribute handling to come aft

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

2023-07-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D151373#4533550 , @fridtjof wrote: > I fixed the failing IBOutletCollection.m test - there was code to do special > handling for the respective attribute type, which my patch accidentally > skipped previously. I reorder

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

2023-05-24 Thread Fridtjof Mund via Phabricator via cfe-commits
fridtjof created this revision. fridtjof added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. fridtjof requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This enables easy consumption of arbitrary

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

2023-06-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Thank you for the additions! This should have test coverage in clang/unitttests/libclang/LibclangTest.cpp and a release note. Comment at: clang/tools/libclang/CIndex.cpp:2745 } +// TODO these two methods are exactly the same. Can this be express

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

2023-06-10 Thread Fridtjof Mund via Phabricator via cfe-commits
fridtjof updated this revision to Diff 530219. fridtjof added a comment. - Deduplicated code by using templates (looks a bit ridicilous though) - Release notes entry added - Unit test added CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151373/new/ https://reviews.llvm.org/D151373 Files

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

2023-06-13 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. I think precommit CI may have found a relevant failure: TEST 'Clang :: Index/IBOutletCollection.m' FAILED Script: -- : 'RUN: at line 8'; c:\ws\w5\llvm-project\premerge-checks\build\bin\c-index-test.exe -cursor-a