[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG785b30b8a33a: [clang-tidy] Check for specific return types on all functions (authored by chaitanyav). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav added a comment. In D151383#4377043 , @PiotrZSL wrote: > LGTM, you may consider reducing commit message (aka review description by > removing example and error from it, and leaving just plain description of a > change). got it, will make

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

PiotrZSL accepted this revision. PiotrZSL added a comment. LGTM, you may consider reducing commit message (aka review description by removing example and error from it, and leaving just plain description of a change). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 526173. chaitanyav marked an inline comment as done. chaitanyav added a comment. use fully qualified name in code and documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

PiotrZSL accepted this revision. PiotrZSL added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:129 + CheckedReturnTypes(utils::options::parseStringList( +

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 526159. chaitanyav marked 4 inline comments as done. chaitanyav added a comment. Make changes as per comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:159 + anyOf(isInstantiatedFrom(hasAnyName(FunVec)), + hasAnyReturnType(RetTypeVec) .bind("match";

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:398 + Removed checks Excessive newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 525926. chaitanyav marked an inline comment as done. chaitanyav added a comment. Use single backticks for options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:394 +- Extend ``bugprone-unused-return-value`` check to check for all functions + with specified return types using the ``CheckedReturnTypes`` option. Please keep

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav added a comment. please let me know if there is better way to do the matching `hasAnyReturnType`. We could also sort then do binarysearch instead of looping through the list of ret types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 525855. chaitanyav added a comment. Add tests, update docs and extend matchcallexpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383 Files:

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. - Missing tests - Missing release notes - Missing check documentation update Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:159

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

chaitanyav updated this revision to Diff 525359. chaitanyav added a comment. Reuse diag code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383 Files:

[PATCH] D151383: [clang-tidy] Check for specific return types on all functions

Eugene.Zelenko added a comment. Please extend test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151383/new/ https://reviews.llvm.org/D151383 ___ cfe-commits mailing list