This revision was automatically updated to reflect the committed changes.
Closed by commit rGa26bd95325f1: [LinkerWrapper] Fix static library symbol
resolution (authored by jhuber6).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151839/new/
https://
jhuber6 added inline comments.
Comment at: clang/test/Driver/linker-wrapper-libs.c:27
//
// Check that we extract a static library defining an undefined symbol.
//
tra wrote:
> jhuber6 wrote:
> > tra wrote:
> > > How does this test test the functionality of th
jhuber6 updated this revision to Diff 527240.
jhuber6 added a comment.
Fix test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151839/new/
https://reviews.llvm.org/D151839
Files:
clang/test/Driver/linker-wrapper-libs.c
clang/tools/clang-linker-
tra added inline comments.
Comment at: clang/test/Driver/linker-wrapper-libs.c:27
//
// Check that we extract a static library defining an undefined symbol.
//
jhuber6 wrote:
> tra wrote:
> > How does this test test the functionality of the undefined symbol? E
jhuber6 added inline comments.
Comment at: clang/test/Driver/linker-wrapper-libs.c:27
//
// Check that we extract a static library defining an undefined symbol.
//
tra wrote:
> How does this test test the functionality of the undefined symbol? E.g. how
> does
tra added a comment.
LGTM in general.
Comment at: clang/test/Driver/linker-wrapper-libs.c:27
//
// Check that we extract a static library defining an undefined symbol.
//
How does this test test the functionality of the undefined symbol? E.g. how
does it fa
jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, tra,
yaxunl.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits, jplehr, sstefan1.
Herald added a project: clang.
The linker wrapper perfo
