[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

jansvoboda11 added a comment. In D151938#4645381 , @Jake-Egan wrote: > @jansvoboda11 Actually, we could give you access to an AIX machine to debug > this. Would that work for you? Hi, I'd be happy to try that! Repository: rG LLVM Github Monorepo CH

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

Jake-Egan added a comment. @jansvoboda11 Actually, we could give you access to an AIX machine to debug this. Would that work for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151938/new/ https://reviews.llvm.org/D151938 _

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

Jake-Egan added a comment. @jansvoboda11 Thanks for taking care of the other tests. I'm not sure how this could be reproduced not on AIX. I'll have to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151938/new/ https://reviews.llvm.org/

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

jansvoboda11 added a comment. In D151938#4626992 , @Jake-Egan wrote: > Sorry for the late response @jansvoboda11, when `lookupModuleFile` is called, > the file > `build/tools/clang/test/Index/Core/Output/index-with-module.m.tmp.mcp/A03A61VI43WA/ModA-21U

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

Jake-Egan added a comment. Sorry for the late response @jansvoboda11, when `lookupModuleFile` is called, the file `build/tools/clang/test/Index/Core/Output/index-with-module.m.tmp.mcp/A03A61VI43WA/ModA-21USRMHJNU3PG.pcm` doesn't exist. So it seems there's some issue with the creation of the fil

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

jansvoboda11 added inline comments. Comment at: clang/tools/libclang/CXFile.h:18 +inline CXFile makeCXFile(OptionalFileEntryRef FE) { + return CXFile(FE ? &FE->getMapEntry() : nullptr); +} uabelho wrote: > Gcc warns here: > ``` > ../../clang/tools/libclang/CXFil

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

uabelho added inline comments. Comment at: clang/tools/libclang/CXFile.h:18 +inline CXFile makeCXFile(OptionalFileEntryRef FE) { + return CXFile(FE ? &FE->getMapEntry() : nullptr); +} Gcc warns here: ``` ../../clang/tools/libclang/CXFile.h:18:50: warning: cast f

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

jansvoboda11 added a comment. In D151938#4426106 , @Jake-Egan wrote: > Hi, there's a test failure on AIX, could you take a look please? > > https://lab.llvm.org/buildbot/#/builders/214/builds/8005/steps/6/logs/FAIL__Clang__index-with-module_m Thanks for

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

Jake-Egan added a comment. Hi, there's a test failure on AIX, could you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/8005/steps/6/logs/FAIL__Clang__index-with-module_m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151938/

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa5788ff8dc1: [clang][index] NFCI: Make `CXFile` a `FileEntryRef` (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

jansvoboda11 added inline comments. Comment at: clang/test/Modules/crash-vfs-umbrella-frameworks.m:13 // RUN: env FORCE_CLANG_DIAGNOSTICS_CRASH= TMPDIR=%t TEMP=%t TMP=%t \ -// RUN: not %clang -nostdinc -fsyntax-only %s \ +// RUN: not --crash %clang -nostdinc -fsyntax-only %s \

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

jansvoboda11 updated this revision to Diff 531245. jansvoboda11 marked 3 inline comments as done. jansvoboda11 added a comment. Remove accidental diff with `--crash` in test, add file header, continue being defensive in `CXLoadedDiagnostic.cpp`. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

benlangmuir added inline comments. Comment at: clang/test/Modules/crash-vfs-umbrella-frameworks.m:13 // RUN: env FORCE_CLANG_DIAGNOSTICS_CRASH= TMPDIR=%t TEMP=%t TMP=%t \ -// RUN: not %clang -nostdinc -fsyntax-only %s \ +// RUN: not --crash %clang -nostdinc -fsyntax-only %s \ /

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, bnbarham. Herald added subscribers: ributzka, arphaman. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch swap