Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

mcrosier closed this revision. mcrosier added a comment. Committed in r256937. Thanks, Bob. http://reviews.llvm.org/D15195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

bob.wilson accepted this revision. bob.wilson added a comment. This revision is now accepted and ready to land. This looks good to me. Thanks for working on this! http://reviews.llvm.org/D15195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

mcrosier added a comment. Ping. http://reviews.llvm.org/D15195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

mcrosier added a comment. Ping. I promise this is fairly straight forward. :) http://reviews.llvm.org/D15195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

mcrosier updated this revision to Diff 42854. mcrosier added a comment. Remove the FIXME, per Hal and Bob's request. I confirmed that gcc does not warn for invalid -fno-builtin-foo options. Also, pass the vector by reference and insert, rather than making an unnecessary copy on the return in Co

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

bob.wilson added a comment. Regarding the FIXME in lib/Frontend/CompilerInvocation.cpp: I agree with Hal that you can remove that. We used to complain about unsupported -fno-builtin-* options (and until now they have *all* been unsupported), but in r191434, Rafael changed clang to silently igno

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

hfinkel added a comment. In http://reviews.llvm.org/D15195#310395, @mcrosier wrote: > In http://reviews.llvm.org/D15195#307136, @hfinkel wrote: > > > Can you use a StringSet instead of a vector and avoid all (most) of the > > code iterating over the vector of builtins being disabled? > > > Hi Ha

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

mcrosier added a comment. In http://reviews.llvm.org/D15195#307136, @hfinkel wrote: > Can you use a StringSet instead of a vector and avoid all (most) of the code > iterating over the vector of builtins being disabled? Hi Hal, I began converting the code to use StringSets, but I soon realized

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

hfinkel added a subscriber: hfinkel. hfinkel added a comment. Can you use a StringSet instead of a vector and avoid all (most) of the code iterating over the vector of builtins being disabled? Comment at: lib/Frontend/CompilerInvocation.cpp:147 @@ +146,3 @@ +Values.push

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

mcrosier added a comment. Ping. http://reviews.llvm.org/D15195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

mcrosier created this revision. mcrosier added reviewers: majnemer, doug.gregor, ddunbar, chandlerc, bob.wilson, rnk, krememek. mcrosier added a subscriber: cfe-commits. The changes adds support for -fno-builtin-foo options. This addresses PR4941 and rdar://6756912. Please take a look. Chad