[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

tstellar added a comment. I chatted with @compnerd on Discord, and I'm going to try to update D109192 and get that committed and then come back to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

aaron.ballman added subscribers: majnemer, rnk. aaron.ballman added a comment. I seem to recall this came up in the past and there were issues, so I did some digging around our mail archives and figured I'd share what I found:

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

tstellar added a comment. > ! In D152051#4403167 , @compnerd > wrote: > Please do not use LLVM_EXTERNAL_VISIBILITY but rather introduce a new macro > (this will prevent the use on Windows). OK, so should I create a clang specific macro for this? And

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

compnerd added a comment. In D152051#4392612 , @tstellar wrote: > I was not sure what to do with inline functions and also functions that were > implemented in the headers, so I did not add the LLVM_EXTERNAL_VISIBILITY > macro to most of those

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:4532 /// Returns ``true`` if the Style has been set. -bool getPredefinedStyle(StringRef Name, FormatStyle::LanguageKind Language, +LLVM_EXTERNAL_VISIBILITY bool

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

tstellar added a comment. I was not sure what to do with inline functions and also functions that were implemented in the headers, so I did not add the LLVM_EXTERNAL_VISIBILITY macro to most of those functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

tstellar created this revision. Herald added subscribers: cfe-commits, PiotrZSL, luke, steakhal, carlosgalvezp, frasercrmck, wenlei, luismarques, apazos, sameer.abuasal, s.egerton, Jim, mstorsjo, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27,