[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines= as a driver option

TWeaver added a comment. Thanks for the fix!  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines= as a driver option

TWeaver added a comment. Hello and good afternoon from the UK, It looks as though this change has caused the following buildbot to start failing (it's temporarily on staging server so you may not have seen it on the public build bot page):

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines= as a driver option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rG5cc721b3f96e: [clang][Driver] Add -fcaret-diagnostics-max-lines= as a driver option (authored by tbaeder).

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines= as a driver option

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/include/clang/Driver/Options.td:2303 + Group, Flags<[NoXarchOption, CC1Option, CoreOption]>, + HelpText<"Set the maximum number of source lines to show in a caret diagnostic">, +

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines= as a driver option

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/include/clang/Driver/Options.td:2303 + Group, Flags<[NoXarchOption, CC1Option, CoreOption]>, + HelpText<"Set the maximum number of source lines

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

tbaeder updated this revision to Diff 530168. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

MaskRay added a comment. In D152090#4407632 , @dyung wrote: > If we do not accept the form "`-fcaret-diagnostics-max-lines n`", can we add > a negative for that? Or if we do a positive test for it as well? I think this is not very useful. This is a new

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

tbaeder updated this revision to Diff 529832. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/Driver/caret-diagnostics-max-lines.cpp:1 +//RUN: not %clang++ -fsyntax-only -fcaret-diagnostics-max-lines=2 %s 2>&1 | FileCheck %s -strict-whitespace + MaskRay

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

dyung added a comment. If we do not accept the form "`-fcaret-diagnostics-max-lines n`", can we add a negative for that? Or if we do a positive test for it as well? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

MaskRay added a comment. > Add -fcaret-diagnostics-max-lines as a driver option `-fcaret-diagnostics-max-lines=` is more accurate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 ___ cfe-commits

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:2303 + Group, Flags<[NoXarchOption, CC1Option, CoreOption]>, + HelpText<"Set the maximum number of source lines to show in a caret diagnostic">, + MarshallingInfoInt,

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

tbaeder updated this revision to Diff 529818. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Options.td

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

MaskRay added a comment. In D152090#4398097 , @tbaeder wrote: > In D152090#4395827 , @MaskRay wrote: > >> `def fcaret_diagnostics_max_lines` in `Options.td` has the `NoDriverOption` >> flag. Move it to other

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

aaron.ballman added a comment. In D152090#4395192 , @hans wrote: > Should there be a test? +1 Also, a release note so users know about the public-facing option? Comment at: clang/include/clang/Driver/Options.td:1611 def

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

tbaeder added a comment. In D152090#4395827 , @MaskRay wrote: > `def fcaret_diagnostics_max_lines` in `Options.td` has the `NoDriverOption` > flag. Move it to other places with `BooleainFFlag` should work. > Then in `Clang.cpp` you can just write

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

MaskRay added a comment. `def fcaret_diagnostics_max_lines` in `Options.td` has the `NoDriverOption` flag. Move it to other places with `BooleainFFlag` should work. Then in `Clang.cpp` you can just write `Args.AddLastArg(...)` Can you add some description that this is related to D147875

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

hans added a comment. Should there be a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, MaskRay. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D152090