[PATCH] D152369: [clang][dataflow][NFC] Expand comments on losing values in optional checker.

2023-06-12 Thread Martin Böhme via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbeda83090ad: [clang][dataflow][NFC] Expand comments on losing values in optional checker. (authored by mboehme). Repository: rG LLVM Github Monor

[PATCH] D152369: [clang][dataflow][NFC] Expand comments on losing values in optional checker.

2023-06-12 Thread Martin Böhme via Phabricator via cfe-commits
mboehme added a comment. libcxx failures look unrelated (this is a comment-only change that doesn't touch libcxx) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152369/new/ https://reviews.llvm.org/D152369 _

[PATCH] D152369: [clang][dataflow][NFC] Expand comments on losing values in optional checker.

2023-06-07 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Nice! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152369/new/ https://reviews.llvm.org/D152369 _

[PATCH] D152369: [clang][dataflow][NFC] Expand comments on losing values in optional checker.

2023-06-07 Thread Martin Böhme via Phabricator via cfe-commits
mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. While working on the ongoing migration to strict