[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b0ea4874093: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation (authored by alexander-shaposhnikov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov updated this revision to Diff 529801. alexander-shaposhnikov added a comment. Add missing parentheses Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152403/new/ https://reviews.llvm.org/D152403 Files:

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with a nit. Comment at: clang/lib/Sema/SemaType.cpp:8168 +IsTargetCUDAAndHostARM = +!AuxTI || AuxTI->getTriple().isAArch64() || AuxTI->getTriple().isARM(); + }

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov updated this revision to Diff 529795. alexander-shaposhnikov marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152403/new/ https://reviews.llvm.org/D152403 Files: clang/lib/Sema/SemaType.cpp

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov updated this revision to Diff 529794. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152403/new/ https://reviews.llvm.org/D152403 Files: clang/lib/Sema/SemaType.cpp

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8168 +IsTargetCUDAAndHostARM = +!AuxTI || AuxTI->getTriple().isAArch64() || AuxTI->getTriple().isARM(); + } tra wrote: > Should it be `AuxTI &&

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov added inline comments. Comment at: clang/test/SemaCUDA/neon-attrs.cu:2 +// RUN: %clang_cc1 -triple arm64-linux-gnu -target-feature +neon -x cuda -fsyntax-only -DNO_DIAG -verify %s +// RUN: %clang_cc1 -triple arm64-linux-gnu -target-feature -neon -x cuda

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

tra added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8168 +IsTargetCUDAAndHostARM = +!AuxTI || AuxTI->getTriple().isAArch64() || AuxTI->getTriple().isARM(); + } Should it be `AuxTI && (AuxTI->getTriple().isAArch64() ||

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

alexander-shaposhnikov created this revision. alexander-shaposhnikov added a reviewer: tra. alexander-shaposhnikov created this object with visibility "All Users". Herald added subscribers: mattd, carlosgalvezp, yaxunl. Herald added a project: All. alexander-shaposhnikov requested review of this