[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

jan-wassenberg added a comment. Thanks for your quick reply. Yes, we are tracking trunk with a short lag, and unfortunately this is mostly beyond our control. Now that I have updated the Highway code and toolchain reference in user code, we are fine for the moment. Please do update the

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

eopXD added a comment. In D152879#4440356 , @jan-wassenberg wrote: > Is there a way to detect whether the compiler already includes this change, > preferably via preprocessor? > I tried `#ifdef __RISCV_VXRM_RDN` and `#if

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

jan-wassenberg added a comment. Is there a way to detect whether the compiler already includes this change, preferably via preprocessor? I tried `#ifdef __RISCV_VXRM_RDN` and `#if __has_builtin(__RISCV_VXRM_RDN)`. This is a breaking change for us. Updating code to the new required signature

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ed668ad9321: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

eopXD updated this revision to Diff 532830. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152879/new/ https://reviews.llvm.org/D152879 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

eopXD updated this revision to Diff 532532. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152879/new/ https://reviews.llvm.org/D152879 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2269 + +IntrinsicTypes = {ResultType, Ops[Offset]->getType(), Ops[Offset + 1]->getType(), + Ops.back()->getType()}; craig.topper wrote: > I think

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2269 + +IntrinsicTypes = {ResultType, Ops[Offset]->getType(), Ops[Offset + 1]->getType(), + Ops.back()->getType()}; I think we if we used

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

eopXD added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:697 +: DefaultAttrsIntrinsic<[llvm_anyvector_ty], +[LLVMMatchType<0>, llvm_anyvector_ty, llvm_any_ty, + LLVMScalarOrSameVectorWidth<0, llvm_i1_ty>,

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152879/new/ https://reviews.llvm.org/D152879

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

craig.topper added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:697 +: DefaultAttrsIntrinsic<[llvm_anyvector_ty], +[LLVMMatchType<0>, llvm_anyvector_ty, llvm_any_ty, + LLVMScalarOrSameVectorWidth<0,

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

eopXD updated this revision to Diff 531178. eopXD added a comment. Resolve test case failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152879/new/ https://reviews.llvm.org/D152879 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

eopXD updated this revision to Diff 531157. eopXD added a comment. Resolve test case failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152879/new/ https://reviews.llvm.org/D152879 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, arcbbb, rogfer01, reames. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,