[PATCH] D152880: [clang][NFC] Add a notice to desugarForDiagnostic

2023-06-14 Thread Younan Zhang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0e08374abb2c: [clang][NFC] Add a notice to desugarForDiagnostic (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152880/new/ https://rev

[PATCH] D152880: [clang][NFC] Add a notice to desugarForDiagnostic

2023-06-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the extra documentation, that is a surprising behavior Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152880/new

[PATCH] D152880: [clang][NFC] Add a notice to desugarForDiagnostic

2023-06-13 Thread Younan Zhang via Phabricator via cfe-commits
zyounan created this revision. Herald added a project: All. zyounan added reviewers: aaron.ballman, lh123. zyounan published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. `desugarForDiagnostic` only sets ShouldAKA to true if desugaring happens, ot