This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc8c583071591: Fix diag for read-only target features
(authored by yaxunl).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHA
yaxunl updated this revision to Diff 532284.
yaxunl added a comment.
use -verify in test
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153123/new/
https://reviews.llvm.org/D153123
Files:
clang/lib/Basic/TargetInfo.cpp
clang/lib/Basic/Targets.cpp
clang/test/OpenMP/openmp-read-only
jhuber6 added inline comments.
Comment at: clang/test/OpenMP/driver-openmp-amdgpu.c:8
+// RUN: --offload-device-only -o - 2>&1 | FileCheck --check-prefix=CHECK %s
+// CHECK-NOT: warning: feature flag {{.*}} is ignored since the feature is
read only
jdoerfert w
jdoerfert added inline comments.
Comment at: clang/test/OpenMP/driver-openmp-amdgpu.c:8
+// RUN: --offload-device-only -o - 2>&1 | FileCheck --check-prefix=CHECK %s
+// CHECK-NOT: warning: feature flag {{.*}} is ignored since the feature is
read only
yaxunl wr
yaxunl added inline comments.
Comment at: clang/test/OpenMP/driver-openmp-amdgpu.c:8
+// RUN: --offload-device-only -o - 2>&1 | FileCheck --check-prefix=CHECK %s
+// CHECK-NOT: warning: feature flag {{.*}} is ignored since the feature is
read only
arsenm wrote
arsenm added inline comments.
Comment at: clang/test/OpenMP/driver-openmp-amdgpu.c:8
+// RUN: --offload-device-only -o - 2>&1 | FileCheck --check-prefix=CHECK %s
+// CHECK-NOT: warning: feature flag {{.*}} is ignored since the feature is
read only
Can you use
yaxunl created this revision.
yaxunl added reviewers: tra, jhuber6, arsenm.
Herald added subscribers: kerbowa, jvesely.
Herald added a project: All.
yaxunl requested review of this revision.
Herald added subscribers: jplehr, sstefan1, wdng.
Herald added a reviewer: jdoerfert.
Currently the diag is
