[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot added a comment. I've pushed some WIP change to inform that I'm still working on this topic :) Not sure if I also need to submit a comment to publish what I've marked as "done" via checkboxes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot updated this revision to Diff 556283. robot marked 3 inline comments as done. robot added a comment. Herald added a project: clang. WIP - several improvements I thought it might be a good idea to give an update even though this is still work in progress. - Don't print `virtual` for added d

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

sammccall added a comment. In D153152#4617391 , @robot wrote: >> so you could replace the logic that prints the return type + arg list with >> `printType(functype, class, methodname)` (from AST.h). That should pick up >> noexcept etc. > > I've tried it

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot added a comment. > so you could replace the logic that prints the return type + arg list with > `printType(functype, class, methodname)` (from AST.h). That should pick up > noexcept etc. I've tried it and it's not obvious to me how to do it properly: Since `printType` wants to print the

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot marked an inline comment as done. robot added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DeclarePureVirtuals.cpp:58 + + const llvm::ArrayRef Tokens = + TokBuf.expandedTokens(MethodDeclRange); sammccall wrote: > robot wrote:

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DeclarePureVirtuals.cpp:58 + + const llvm::ArrayRef Tokens = + TokBuf.expandedTokens(MethodDeclRange); robot wrote: > sammccall wrote: > > copying the tokens directly seem

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot planned changes to this revision. robot marked 3 inline comments as done. robot added a comment. I'm working on the comments, but it will take a while. Comment at: clang-tools-extra/clangd/refactor/tweaks/DeclarePureVirtuals.cpp:58 + + const llvm::ArrayRef Tokens = +

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

sammccall added a comment. Thanks for working on this! FWIW I had an old draft of this feature that may have interesting ideas: https://reviews.llvm.org/D122827 Comment at: clang-tools-extra/clangd/refactor/tweaks/DeclarePureVirtuals.cpp:44 +for (const auto &WhatIsThis :

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot updated this revision to Diff 532575. robot added a comment. Remove left-over test file of other ptch from CMakeLists.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153152/new/ https://reviews.llvm.org/D153152 Files: clang-tools-extra/c

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot updated this revision to Diff 532199. robot added a comment. Remove left-over file of other patch from CMakeLists.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153152/new/ https://reviews.llvm.org/D153152 Files: clang-tools-extra/clang

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot added a comment. This change is not done, I need some advice: - I don't understand why there are two levels of data structures in an entry of the final overriders map, hence I can't properly name the variables nor do I fully understand what I'm doing there. - It's not clear if the tweak s

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot created this revision. robot added a reviewer: sammccall. Herald added subscribers: ChuanqiXu, kadircet, arphaman. Herald added a project: All. robot requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This tweak searches the