[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir added a comment. Thank you @aaron.ballman and @Fznamznon for reviewing! I landed this patch with commit d2fafa79ef08f9ef9cd0108a6caa7fc61a31bdeb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2fafa79ef08: [NFC] Fix potential dereferencing of nullptr. (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153236/new/ https://review

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153236/new/ https://reviews.llvm.org/D153236 ___ cfe-commits mailing lis

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:886-887 TopLevelCase = Case; - else + else { +assert(DeepestParsedCaseStmt && "DeepestParsedCaseStmt cannot be null"); Actions.ActOnCaseStmtBody(DeepestParsedCaseStmt, C

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir updated this revision to Diff 533386. schittir marked 3 inline comments as done. schittir added a comment. Changes to address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153236/new/ https://reviews.llvm.org/D153236 Files: clang/lib/Sema/SemaExprObjC.cpp clang/l

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:886-887 TopLevelCase = Case; - else + else { +assert(DeepestParsedCaseStmt && "DeepestParsedCaseStmt cannot be null"); Actions.ActOnCaseStmtBody(DeepestParsedCaseSt

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:887 + else { +assert(DeepestParsedCaseStmt && "DeepestParsedCaseStmt cannot be null"); Actions.ActOnCaseStmtBody(DeepestParsedCaseStmt, Case.get()); Fznamznon wrote:

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

Fznamznon added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:887 + else { +assert(DeepestParsedCaseStmt && "DeepestParsedCaseStmt cannot be null"); Actions.ActOnCaseStmtBody(DeepestParsedCaseStmt, Case.get()); The assert that

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir updated this revision to Diff 532528. schittir added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153236/new/ https://reviews.llvm.org/D153236 Files: clang/lib/Parse/ParseStmt.cpp clang/lib/Sema/SemaExprObjC.cpp clang/lib/Sema/SemaObjCProperty.cpp

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

schittir created this revision. schittir added reviewers: aaron.ballman, tahonermann, erichkeane. Herald added a project: All. schittir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Replace getAs with castAs and add assert if needed. Re