This revision was automatically updated to reflect the committed changes.
Closed by commit rG028c1033b1ed: [Driver][BareMetal] Error if no matching
multilib (authored by michaelplatings).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153292/new/
htt
michaelplatings marked an inline comment as done.
michaelplatings added a comment.
Thanks @simon_tatham. I agree there's definitely scope to improve this. The
behaviour is quite specific so I kept the code in the BareMetal toolchain
rather than as part of the core Multilib class. Other toolchain
simon_tatham accepted this revision.
simon_tatham added a comment.
This revision is now accepted and ready to land.
LGTM.
One of the thoughts I mentioned offline before this patch was written was that
maybe the error would need to be conditional, via a directive inside
`multilib.yaml` itself –
michaelplatings created this revision.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
michaelplatings requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
Previously if no matching multilib was found then the user
