[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jrbyrnes updated this revision to Diff 535456. jrbyrnes added a comment. Naming + -cuda-device-only and -fno-gpu-rdc only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153667/new/ https://reviews.llvm.org/D153667 Files: clang/include/clang/Drive

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jrbyrnes added a comment. In D153667#4450724 , @jhuber6 wrote: > In D153667#4450705 , @jrbyrnes > wrote: > >> In D153667#4450517 , @jhuber6 >> wrote: >> >>> What's the d

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

yaxunl added a comment. In D153667#4455998 , @jhuber6 wrote: > In D153667#4455943 , @yaxunl wrote: > >> For -fno-gpu-rdc case we do not use lto. Since -fno-gpu-rdc has one TU only, >> we use the non-lto backend t

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

yaxunl added a comment. I am thinking we probably want to rename the option as -fhip-emit-relocatable and limit it to be used with -cuda-device-only and -fno-gpu-rdc only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153667/new/ https://reviews.l

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jhuber6 added a comment. In D153667#4455943 , @yaxunl wrote: > For -fno-gpu-rdc case we do not use lto. Since -fno-gpu-rdc has one TU only, > we use the non-lto backend to get relocatable object, and use lld for > relocatable to shared object. This patc

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

yaxunl added a comment. In D153667#4450724 , @jhuber6 wrote: > In D153667#4450705 , @jrbyrnes > wrote: > >> In D153667#4450517 , @jhuber6 >> wrote: >> >>> What's the dif

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jhuber6 added a comment. In D153667#4450705 , @jrbyrnes wrote: > In D153667#4450517 , @jhuber6 wrote: > >> What's the difference here between this and the existing `--hip-link`? > > Hi @jhuber6 > > The commit is p

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jrbyrnes added a comment. In D153667#4450517 , @jhuber6 wrote: > What's the difference here between this and the existing `--hip-link`? Hi @jhuber6 The commit is poorly named, the main purpose is to introduce `-no-gpu-link-output.` We want a way to pr

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jhuber6 added a comment. What's the difference here between this and the existing `--hip-link`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153667/new/ https://reviews.llvm.org/D153667 ___ cfe-commits

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jrbyrnes updated this revision to Diff 534725. jrbyrnes marked an inline comment as done. jrbyrnes added a comment. Fix tests + add tests. Add phase test for -fgpu-rdc --no-gpu-link-output (these are not intended to be used together) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

yaxunl added inline comments. Comment at: clang/test/Driver/hip-phases.hip:259 +// RELOC-DAG: [[P4:[0-9]+]]: assembler, {[[P3]]}, object, (device-[[T]], [[ARCH]]) +// RELOC-NOT: [[P5:[0-9]+]]: linker, {[[P4]]}, image, (device-[[T]], [[ARCH]]) +// RELOC-DAG: [[P5:[0-9]+]]: offloa

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jrbyrnes updated this revision to Diff 534086. jrbyrnes added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153667/new/ https://reviews.llvm.org/D153667 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver

[PATCH] D153667: [HIP]: Add gpu-link-output to control link job creation

jrbyrnes created this revision. jrbyrnes added a reviewer: yaxunl. Herald added a project: All. jrbyrnes requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Change-Id: Ia19a28867d15022d1400d3e18c61f14259057ff4 Repository: rG LLVM Gi