[PATCH] D153689: [clang][Interp] Handle CXXConstructExprs

2023-08-16 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder abandoned this revision. tbaeder added a comment. Superseeded by https://reviews.llvm.org/D156027. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153689/new/ https://reviews.llvm.org/D153689 ___ c

[PATCH] D153689: [clang][Interp] Handle CXXConstructExprs

2023-07-26 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1109 +template +bool ByteCodeExprGen::VisitCXXConstructExpr( +const CXXConstructExpr *E) { Should we be checking `isElidable()`? Repository: rG LLVM Github Monorepo CHANG

[PATCH] D153689: [clang][Interp] Handle CXXConstructExprs

2023-07-25 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153689/new/ https://reviews.llvm.org/D153689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D153689: [clang][Interp] Handle CXXConstructExprs

2023-07-17 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153689/new/ https://reviews.llvm.org/D153689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D153689: [clang][Interp] Handle CXXConstructExprs

2023-06-28 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. I think this makes https://reviews.llvm.org/D153653 unnecessary(?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153689/new/ https://reviews.llvm.org/D153689 ___ cfe-commits mail

[PATCH] D153689: [clang][Interp] Handle CXXConstructExprs

2023-06-23 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes a so far broken Lambda test case. Repositor