tbaeder abandoned this revision.
tbaeder added a comment.
Superseeded by https://reviews.llvm.org/D156027.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153689/new/
https://reviews.llvm.org/D153689
___
c
shafik added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1109
+template
+bool ByteCodeExprGen::VisitCXXConstructExpr(
+const CXXConstructExpr *E) {
Should we be checking `isElidable()`?
Repository:
rG LLVM Github Monorepo
CHANG
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153689/new/
https://reviews.llvm.org/D153689
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153689/new/
https://reviews.llvm.org/D153689
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
tbaeder added a comment.
I think this makes https://reviews.llvm.org/D153653 unnecessary(?)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153689/new/
https://reviews.llvm.org/D153689
___
cfe-commits mail
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes a so far broken Lambda test case.
Repositor