[PATCH] D153770: Fix test regression on 32-bit x86.

2023-06-29 Thread Zahira Ammarguellat via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fd3321db742: Fix test regression on 32-bit x86. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D153770: Fix test regression on 32-bit x86.

2023-06-29 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam updated this revision to Diff 535783. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153770/new/ https://reviews.llvm.org/D153770 Files: clang/test/Sema/fp-eval-pragma-with-float-double_t-1.c clang/test/Sema/fp-eval-pragma-with-float-double_t-2.c

[PATCH] D153770: Fix test regression on 32-bit x86.

2023-06-28 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam updated this revision to Diff 535368. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153770/new/ https://reviews.llvm.org/D153770 Files: clang/test/Sema/fp-eval-pragma-with-float-double_t-1.c clang/test/Sema/fp-eval-pragma-with-float-double_t-2.c

[PATCH] D153770: Fix test regression on 32-bit x86.

2023-06-26 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. In D153770#4449154 , @zahiraam wrote: > In D153770#4449078 , @mgorny wrote: > >> I think you also need to require `X86` target but I'm not 100% sure. > > I don't think so. That warning was

[PATCH] D153770: Fix test regression on 32-bit x86.

2023-06-26 Thread Michał Górny via Phabricator via cfe-commits
mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks. I can confirm that this fixes the test failures for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153770/new/

[PATCH] D153770: Fix test regression on 32-bit x86.

2023-06-26 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam added a comment. In D153770#4449078 , @mgorny wrote: > I think you also need to require `X86` target but I'm not 100% sure. I don't think so. That warning was legal and is related to the option ffp-eval-method. I could have added run lines in

[PATCH] D153770: Fix test regression on 32-bit x86.

2023-06-26 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. I think you also need to require `X86` target but I'm not 100% sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153770/new/ https://reviews.llvm.org/D153770 ___ cfe-commits

[PATCH] D153770: Fix test regression on 32-bit x86.

2023-06-26 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam created this revision. zahiraam added reviewers: rjmccall, mgorny. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Issue found after merging of patch: https://reviews.llvm.org/D153590 Repository: rG LLVM Github Monorepo