[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 547619. sstwcw added a comment. Add support for breaking strings with + in C# and others Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files:

[PATCH] D154093: [clang-format] Break long strings in Verilog

owenpan added a comment. In D154093#4542339 , @sstwcw wrote: > @owenpan What do you think about this revision especially the replacement > part? See D154093#4544495 . Then we can extend it by using `,` instead

[PATCH] D154093: [clang-format] Break long strings in Verilog

owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:2152-2154 // FIXME: String literal breaking is currently disabled for C#, Java, Json // and JavaScript, as it requires strings to be merged using "+" which we // don't support.

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw added a comment. @owenpan What do you think about this revision especially the replacement part? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 ___

[PATCH] D154093: [clang-format] Break long strings in Verilog

HazardyKnusperkeks added a comment. For the replacement part, I refer to @owenpan and/or @MyDeveloperDay hoping they have more insight. The rest look good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 542916. sstwcw added a comment. - Add comment explaining the replacements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files:

[PATCH] D154093: [clang-format] Break long strings in Verilog

HazardyKnusperkeks added a comment. Apart from that I'm okay. Comment at: clang/lib/Format/WhitespaceManager.cpp:1428 + // case, it is allowed if there is a replacement for the empty range + // between 2 tokens and another non-empty range at the start of the second

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw marked an inline comment as done. sstwcw added a comment. Are there any more problems? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 ___ cfe-commits

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw marked an inline comment as done. sstwcw added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:2247 bool DryRun, bool Strict) { - std::unique_ptr Token = + std::unique_ptr Token =

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 540752. sstwcw added a comment. - Add back the const qualifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D154093: [clang-format] Break long strings in Verilog

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:2247 bool DryRun, bool Strict) { - std::unique_ptr Token = + std::unique_ptr Token = createBreakableToken(Current, State,

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 540611. sstwcw edited the summary of this revision. sstwcw added a comment. - Add back the const qualifiers for methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 537975. sstwcw marked an inline comment as done. sstwcw added a comment. - Drop the line in the doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files:

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw added a comment. If it is expected that the method does not modify the field, and the expectation is not fulfilled, I prefer to make it clear rather than to pretend that the method works as expected. Can you help me come up with an alternative? Braces need to be added around the

[PATCH] D154093: [clang-format] Break long strings in Verilog

HazardyKnusperkeks added a comment. In D154093#4466597 , @sstwcw wrote: > In D154093#4466246 , > @HazardyKnusperkeks wrote: > >> I'd really prefer you put what you need to modify `mutable` instead of >>

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw added inline comments. Comment at: clang/include/clang/Format/Format.h:1914 ///const char* x = - /// "veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongString"; + ///"veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongString"; /// \endcode

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw marked 2 inline comments as done. sstwcw added a comment. In D154093#4466246 , @HazardyKnusperkeks wrote: > I'd really prefer you put what you need to modify `mutable` instead of > removing the `const` from everything else. But that's just my

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw updated this revision to Diff 536555. sstwcw added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D154093: [clang-format] Break long strings in Verilog

HazardyKnusperkeks added a comment. I'd really prefer you put what you need to modify `mutable` instead of removing the `const` from everything else. But that's just my opinion. Comment at: clang/include/clang/Format/Format.h:1905 + /// + /// In C: /// \code