[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

MyDeveloperDay added a comment. In D154184#4509744 , @rymiel wrote: > Shouldn't that regression already be handled by D155358 > ? nice catch @rymiel! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

krasimir added a comment. In D154184#4509744 , @rymiel wrote: > Shouldn't that regression already be handled by D155358 > ? Ah, I missed that. That fixes it. Thank you! Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

rymiel added a comment. Shouldn't that regression already be handled by D155358 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154184/new/ https://reviews.llvm.org/D154184 ___

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

krasimir added a comment. It looks like this causes a regression in the following example: % cat test.cc struct A { std::unique_ptr operator()(const B& b) const; }; % clang-format -style=google test.cc # should be the same as the input struct A { std::unique_ptr operator()(cons

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f3620e5c9ee: [clang-format] Correctly annotate */&/&& in operator function calls (authored by owenpan). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

owenpan updated this revision to Diff 536566. owenpan added a comment. Re-annotate */&/&& only if `isCpp()` is true. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154184/new/ https://reviews.llvm.org/D154184 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTe

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3320 + // Annotate */&/&& in `operator` function calls as binary operators. + for (const auto *Tok = Line.First; Tok; Tok = Tok->Next) { rymiel wrote: > I assume this extra fixup s

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

owenpan updated this revision to Diff 536501. owenpan added a comment. Don't fix the token type of */&/&& if the line is a function declaration. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154184/new/ https://reviews.llvm.org/D154184 Files: clang/lib/Format/TokenAnnotator.cpp cla

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. Thanks, this probably makes more sense than what I did before Comment at: clang/lib/Format/TokenAnnotator.cpp:3320 + // Annotate */&/&& in `operator` function calls as bin

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

owenpan updated this revision to Diff 536154. owenpan added a comment. Update a unit test to make it more rigorous. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154184/new/ https://reviews.llvm.org/D154184 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTes

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

owenpan updated this revision to Diff 536151. owenpan added a comment. Handle multiple */&/&& in a single `operator` function argument. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154184/new/ https://reviews.llvm.org/D154184 Files: clang/lib/Format/TokenAnnotator.cpp clang/unitte

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

owenpan updated this revision to Diff 536145. owenpan added a comment. Handle `operator` preceded by `return` or `co-return`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154184/new/ https://reviews.llvm.org/D154184 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

owenpan updated this revision to Diff 536139. owenpan added a comment. Early break if `operator` is `TT_FunctionDeclarationName`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154184/new/ https://reviews.llvm.org/D154184 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Fo

[PATCH] D154184: [clang-format] Correctly annotate */&/&& in operator function calls

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Reverts 4986f3f2f220