[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb22a5d46179b: [analyzer] Fix false negative when pass implicit cast nil to nonnull (authored by songruiwang songruiw...@kuaishou.com). Repository:

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I'd say, as tests pass and I and @xazax.hun think that this is an improvement - along with you - then we should merge this as-is and do corrections once reported.

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

tripleCC added a comment. In D154221#4472112 , @steakhal wrote: > @tripleCC Could you clarify the status. Do you need some help or review? Do > you have concerns? > You made some inline comments that I couldn't put into context. @steakhal Yes, I need

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

steakhal added a comment. @tripleCC Could you clarify the status. Do you need some help or review? Do you have concerns? You made some inline comments that I couldn't put into context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154221/new/

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

tripleCC added inline comments. Comment at: clang/test/Analysis/nullability-arc.mm:25 [self foo:nil]; + // expected-warning@-1{{nil passed to a callee that requires a non-null 1st parameter}} I think there should be a warning when we call the foo: method

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

tripleCC added inline comments. Comment at: clang/test/Analysis/nullability-arc.mm:26 [self foo:nil]; -#if __has_feature(objc_arc) - // expected-note@-2{{Calling 'foo:'}} - // expected-note@-3{{Passing nil object reference via 1st parameter 'param'}} -#endif + //

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

tripleCC updated this revision to Diff 537110. tripleCC added a comment. try to fix nullability-arc.mm test case error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154221/new/ https://reviews.llvm.org/D154221 Files:

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. The tests are failing on main. Check the CI bots if they pass on your

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

tripleCC added a comment. I don't have commit access, would you mind committing the revision for me ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154221/new/ https://reviews.llvm.org/D154221 ___