This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6f986bffc51a: [clang] Remove
CGBuilderTy::CreateElementBitCast (authored by JOE1994).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154285/new/
https://reviews.llvm.org/D154285
___
c
JOE1994 updated this revision to Diff 536554.
JOE1994 added a comment.
- Add back in refactorings that either drop existing calls to
CreateElementBitCast, or merge to Address creation.
- Update commit message to clarify that we're employing 3 different methods to
remove existing calls to Create
nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.
The entire change is NFC cleanup, it makes no sense to separate it. Please
revert to previous patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews
jrtc27 accepted this revision.
jrtc27 added a comment.
Thanks for the updated diff (would have also been happy with having a new
commit *before* this one that does the non-trivial changes, but this works too
and can be followed up with the cleanups you were making if you want to)
Repository:
JOE1994 added inline comments.
Comment at: clang/lib/CodeGen/CGBuilder.h:158
/// This method is to be deprecated. Use `Address::withElementType` instead.
+ [[deprecated("Use `Address::withElementType` instead.")]]
jrtc27 wrote:
> jrtc27 wrote:
> > JOE1994 w
