[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a579db32a7a: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1543

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein added a comment. thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154329/new/ https://reviews.llvm.org/D154329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154329/new/ https://reviews.llvm.org/D154329 ___

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

avl added a comment. this LGTM. thanks! Please, wait for approve from Jonas. I think someone from lldb needs to check whether new error reporting is OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154329/new/ https://reviews.llvm.org/D154329 __

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein added inline comments. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:112 return Status("Failed to atomically write file %s", file_spec.GetPath().c_str()); return status; avl wrote: > probably, it would be better to add err

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein updated this revision to Diff 536735. hokein marked an inline comment as done. hokein added a comment. address a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154329/new/ https://reviews.llvm.org/D154329 Files: lldb/tools/lldb-se

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

avl added inline comments. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:112 return Status("Failed to atomically write file %s", file_spec.GetPath().c_str()); return status; probably, it would be better to add error text here? `

[PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein created this revision. hokein added reviewers: avl, JDevlieghere. Herald added a project: All. hokein requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154329 Files: l