[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe90f4fc6acaf: [clang][ExprConstant] Print template arguments when describing stack frame (authored by hazohelet). Repository: rG LLVM Github

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

hazohelet updated this revision to Diff 545216. hazohelet added a comment. Added missing tests for method function templates before landing this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154366/new/ https://reviews.llvm.org/D154366 Files: clang/docs/ReleaseNotes.rst

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

hazohelet added a comment. In D154366#4530536 , @dblaikie wrote: > @hazohelet can you commit this yourself, or do you need someone to commit it > on your behalf? (& if so, what name/email address would you like to be > credited) Thanks for the review.

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

dblaikie added a comment. @hazohelet can you commit this yourself, or do you need someone to commit it on your behalf? (& if so, what name/email address would you like to be credited) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154366/new/ https://reviews.llvm.org/D154366

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

cjdb accepted this revision. cjdb added a comment. If there aren't any concerns from others, then LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154366/new/ https://reviews.llvm.org/D154366 ___ cfe-commits mailing list

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

shafik added a comment. I think this looks fine, I just wonder if we should be adding more tests to make sure we cover the a fuller set of types and non-type template parameters. I feel like this is always what bites us when bugs come up, if we had just test more carefully we would have caught

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154366/new/ https://reviews.llvm.org/D154366 ___ cfe-commits mailing

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

tbaeder added a comment. LGTM from my side, does anyone else still have a problem? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154366/new/ https://reviews.llvm.org/D154366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

hazohelet updated this revision to Diff 540486. hazohelet added a comment. Uses `FunctionDecl::getNameForDiagnostic` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154366/new/ https://reviews.llvm.org/D154366 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant.cpp

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

hazohelet added a comment. `FunctionDecll::getNameForDiagnostic` yields almost the same result and I should use it here. This function internal avoids printing template args that match the defaults, but it doesn't seem to have other techniques to reduce the size of printing. Link:

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

dblaikie added a comment. Do we not already have some function name printing helper we could be reusing that might have some smarts about not printing deduced template arguments, using preferred names, whatever else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

cjdb added a subscriber: dblaikie. cjdb added a comment. Generally in favour of this, but I wonder if we ought to have a way of suppressing it when the specialisation is known and ends up being a gargantuan name (this is a discussion, not an action item). cc @dblaikie Repository: rG LLVM

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, cjdb, shafik. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. This patch adds additional printing of template argument list when the described function is