[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6dccf5b8d550: [clang][analyzer] Add all success/failure messages to… (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

balazske added a comment. About the "`fileno` with standard stream" problem: I do not see an always good solution for this case because these standard streams are global variables. If we want to be exact, we can not know much about these at analysis start unless it is the `main` function. The

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

donat.nagy added a comment. In D154423#4485009 , @balazske wrote: > It would be more simple to handle the standard streams in `StreamChecker` > only. [...] That's a reasonable plan, especially if we can bring that checker out of alpha in the

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

balazske added a comment. It would be more simple to handle the standard streams in `StreamChecker` only. There it is possible to detect standard streams (should be variables with the known names) as arguments to functions. If `StreamChecker` eliminates the failure branch of `fileno` it will

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. Ok, then I think you can finally merge this commit and its two predecessors. I'm happy to see that this improvement is complete. I hope that you can later add a special case for the

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

balazske added a comment. The standard streams may need special handling, this can be useful for `StreamChecker` too. One problem is that the standard streams can be changed by the program, so we can not know for sure if these are the original values. Still it can be better to assume that

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

donat.nagy added a comment. I looked through most of the open source results, and they look promising. However I've seen one questionable tendency: there are many reports (e.g. this one

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

balazske updated this revision to Diff 537346. balazske added a comment. Added AT_FDCWD `openat` test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154423/new/ https://reviews.llvm.org/D154423 Files:

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

balazske added a comment. Results from the last run (the same applies as before, the run postfix `_3` must be selected at top right corner): | memcached_1.6.8_stdclf_notetag_interesting_test_3 | Reports

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

donat.nagy added a comment. These code changes seem to be promising. Please upload results on the open source projects (like the ones that you uploaded previously), and I hope that after verifying those I we can finally merge this set of commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a