NoQ added a comment.
Managed to reproduce the build error with `-fmodules` on my machine.
Committed the updated patch as r257893, the buildbot seems happy.
I hope this review is actually closed now :)
http://reviews.llvm.org/D15448
___
cfe-commits m
NoQ added a reviewer: rsmith.
NoQ added a comment.
Richard: excuse me, adding you because you are an expert on the `modulemap`,
could you have a quick look at the proposed changes here and probably point me
in the right direction, because i'm not quite sure how to test the
modules-enabled build
NoQ removed rL LLVM as the repository for this revision.
NoQ updated this revision to Diff 44758.
NoQ added a comment.
Reverted the patch due to a few issues. This revision should fix these issues.
The explain-svals test is fixed to target a specific target, in order to make
sure that the defini
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257605: [analyzer] Provide .def-files and visitors for
SVal/SymExpr/MemRegion. (authored by dergachev).
Changed prior to commit:
http://reviews.llvm.org/D15448?vs=44734&id=44752#toc
Repository:
rL LL
NoQ added a comment.
Nope, will commit without `SymbolCast` support for now, encountered some issues
with http://reviews.llvm.org/D12901 that would probably be worth a separate
commit.
http://reviews.llvm.org/D15448
___
cfe-commits mailing list
cf
NoQ updated this revision to Diff 44734.
NoQ added a comment.
Rebase on top of http://reviews.llvm.org/D12901 - support `SymbolCast` in the
explainer, as it finally appears in the wild.
http://reviews.llvm.org/D15448
Files:
docs/analyzer/DebugChecks.rst
include/clang/StaticAnalyzer/Checker
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM. Thank you!
http://reviews.llvm.org/D15448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
NoQ updated this revision to Diff 44629.
NoQ added a comment.
Another rebase on top of http://reviews.llvm.org/D16062.
http://reviews.llvm.org/D15448
Files:
docs/analyzer/DebugChecks.rst
include/clang/StaticAnalyzer/Checkers/SValExplainer.h
include/clang/StaticAnalyzer/Core/PathSensitive/
NoQ updated this revision to Diff 44475.
NoQ marked 5 inline comments as done.
NoQ added a comment.
Renamed the kinds for consistency (review http://reviews.llvm.org/D16062), this
diff is updated to use the new naming convention. The 'kind' column gets
removed from the def-files.
http://review
zaks.anna added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/Regions.def:31
@@ +30,3 @@
+// is both instantiated and derived from.
+// Additionally, its kind is not its name with "Kind" suffix,
+// unlike all other regions.
NoQ wrot
NoQ added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/Regions.def:31
@@ +30,3 @@
+// is both instantiated and derived from.
+// Additionally, its kind is not its name with "Kind" suffix,
+// unlike all other regions.
zaks.anna wrot
zaks.anna added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/Regions.def:31
@@ +30,3 @@
+// is both instantiated and derived from.
+// Additionally, its kind is not its name with "Kind" suffix,
+// unlike all other regions.
I'd rath
NoQ updated this revision to Diff 43683.
NoQ marked an inline comment as done.
NoQ added a comment.
An attempt on the .def-files.
The next step would probably be the `VisitChildren()` thing, and I'll see if it
allows to refactor and simplify some code.
__
Forgot to answer: I guess there ar
zaks.anna added a comment.
Are you saying that we need to rename "SymbolValKind" to "SymbolKind"? That
would probably be a tiny change.
http://reviews.llvm.org/D15448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
NoQ added a comment.
Good point, will try to make a .def file.
There's a tiny inconsistency with `SVal` naming that would most likely need to
be fixed in this approach:
nonloc::SymbolVal => SymbolValKind
loc::MemRegionVal => MemRegionKind // no "Val"!
Hmm, maybe make a .def file for symbol
zaks.anna added a comment.
Sorry, I forgot to read the description before commenting; I see it is intended
to be used not only for debugging purposes:)
http://reviews.llvm.org/D15448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
zaks.anna added a comment.
Can/Should something like this be used when dumping SVals (during debugging)?
(Possibly in addition to the debug checker.)
What are the advantages of implementing this using visitors? Can this be
implemented similarly to SVal::dumpToStream? Do you envision other use ca
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin, xazax.hun.
NoQ added a subscriber: cfe-commits.
It seems that in several places in the code Clang Static Analyzer tries to
recursively traverse the `SVal` hierarchy, so i made a visitor for `SVal`,
`SymExpr`, and `MemRegion` h
18 matches
Mail list logo
