[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

arsenm closed this revision. arsenm added a comment. bac2a075408377a8aa41f6626b17bb3e471221f3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154495/new/ https://reviews.llvm.org/D154495

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154495/new/ https://reviews.llvm.org/D154495 ___ cfe-commits mailing list

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154495/new/ https://reviews.llvm.org/D154495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

arsenm added a comment. In D154495#4479481 , @jdoerfert wrote: > FWIW, I assume we want this also for OpenMP offload. I'd be surprised if OpenMP let you do this by default CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154495/new/

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

jdoerfert added a comment. FWIW, I assume we want this also for OpenMP offload. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154495/new/ https://reviews.llvm.org/D154495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

arsenm updated this revision to Diff 537737. arsenm added a comment. Split div/sqrt handling since they have different values. Also cuda does have unimplemented flags to control these individually. Not sure it's worth trying to merge them into one function CHANGES SINCE LAST ACTION

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:5602 +// source are correctly rounded. +SetFPAccuracy(Val, 2.5); + } arsenm wrote: > yaxunl wrote: > > the spec says sqrt relative error is 3ULP > >

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:5602 +// source are correctly rounded. +SetFPAccuracy(Val, 2.5); + } yaxunl wrote: > the spec says sqrt relative error is 3ULP >

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:5602 +// source are correctly rounded. +SetFPAccuracy(Val, 2.5); + } the spec says sqrt relative error is 3ULP

[PATCH] D154495: clang: Attach !fpmath metadata to __builtin_sqrt based on language flags

arsenm created this revision. arsenm added reviewers: yaxunl, Anastasia, jcranmer-intel, tra, jlebar, jhuber6. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: jplehr, sstefan1, wdng. Herald added a reviewer: jdoerfert. OpenCL and HIP have