[PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

mardy added a comment. In D15469#396582 , @jbcoe wrote: > I'll submit a new patch for `isDeleted` on its own. The rest of this patch > seems uncontentious. > > I hope to find time this week to make the changes. Was the patch for isDeleted ever

Re: [PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

This revision was automatically updated to reflect the committed changes. Closed by commit rL267706: Expose cxx constructor and method properties through libclang and python… (authored by jbcoe). Changed prior to commit: http://reviews.llvm.org/D15469?vs=53519=55196#toc Repository: rL LLVM

Re: [PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

jbcoe updated this revision to Diff 53519. jbcoe added a comment. Remove python test for deleted method. I missed this because the python tests are not run as part of check-clang - is this something I could submit a patch to change? http://reviews.llvm.org/D15469 Files:

Re: [PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

skalinichev accepted this revision. skalinichev added a comment. LGTM! Comment at: bindings/python/tests/cindex/test_cursor.py:197 @@ +196,3 @@ + +def test_is_deleted_method(): +"""Ensure Cursor.is_deleted_method works.""" You should remove it too.

Re: [PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

jbcoe updated this revision to Diff 53316. jbcoe added a comment. This revision is now accepted and ready to land. Remove `isDeleted` as it needs to be added for non-member functions. I will add `isDeleted` as an isolated follow up patch. http://reviews.llvm.org/D15469 Files:

Re: [PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

jbcoe added a comment. I plan to strip out the `isDeleted` methods as the associated tests now fail (which I need to raise a bug for) and need reworking to apply to non-member functions. I'll submit a new patch for `isDeleted` on its own. The rest of this patch seems uncontentious. I hope to

Re: [PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

skalinichev added a comment. I see. There were some changes recently in the indexing functionality. I'm not sure whether this change is intended or not, but since it's not your fault and we already have a lot of tests confirming that clang_CXXMethod_isDeleted is working as expected (e.g.

Re: [PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

jbcoe added a comment. If I remove `= delete` from the declaration of the member function `foo` in test/Index/index-file.cpp line 36 then `foo` is reported in the output as [indexDeclaration]: kind: c++-instance-method | name: foo | USR: c:@S@B@F@foo# | lang: C++ | cursor: CXXMethod=foo:36:8

Re: [PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

jbcoe added a comment. I don't know if it's at all helpful but I get the following output from llvm-lit on the failing test file. There's no mention of a function `foo` at all: [startedTranslationUnit] [enteredMainFile]: /Users/jon/DEV/llvm-git-svn/tools/clang/test/Index/index-file.cpp

Re: [PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

jbcoe added a comment. @skalinichev I get the same failure as you. This patch is old now, all tests used to pass. Can you see what is wrong with the test logic? http://reviews.llvm.org/D15469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Sorry about the delay with this change. Thanks for removing the parameter. I think that this is fine as is. Do you have commit rights, or should I commit this on your behalf?

Re: [PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

skalinichev added a comment. Generally looks pretty good to me. Maybe it's worth to factor out duplicating code, but I guess it's not so important. Also the index-file.cpp test failing for me: test/Index/index-file.cpp:57:11: error: expected string not found in input // CHECK: