cor3ntin added a comment.
@MitalAshok Are you still working on this? Do you need further help on this
patch? You have commit access, correct?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154716/new/
https://reviews.llvm.org/D154716
_
cor3ntin accepted this revision.
cor3ntin added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154716/new/
https://reviews.llvm.org/D154716
__
MitalAshok marked an inline comment as done.
MitalAshok added inline comments.
Comment at: clang/lib/Sema/TreeTransform.h:13323
// If this is an init-capture pack, consider expanding the pack now.
if (OldVD->isParameterPack()) {
shafik wrote:
> Based
MitalAshok updated this revision to Diff 543183.
MitalAshok edited the summary of this revision.
MitalAshok added a comment.
Added entry to changelog and the test from the bug report
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154716/new/
https:/
shafik added inline comments.
Comment at: clang/lib/Sema/TreeTransform.h:13323
// If this is an init-capture pack, consider expanding the pack now.
if (OldVD->isParameterPack()) {
Based on the changes is this comment still accurate?
Repository:
rG
shafik added inline comments.
Comment at: clang/test/SemaCXX/lambda-pack-expansion.cpp:36
+
+template void f();
+
Can we also have an example similar to the bug report where we have multiple
arguments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
cor3ntin added a comment.
This looks reasonable to me.
But can you add an entry into clang/docs/ReleaseNotes.rst?
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154716/new/
https://reviews.llvm.org/D154716
_
MitalAshok created this revision.
Herald added a project: All.
MitalAshok edited the summary of this revision.
MitalAshok added reviewers: rsmith, cor3ntin.
MitalAshok published this revision for review.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
When instantiating the
