[PATCH] D154853: [clangd][c++20]Consider the constraint of a constrained auto in FindTarget.

sammccall requested changes to this revision. sammccall added a comment. This revision now requires changes to proceed. (This will look different/better after D155858 , taking it off my radar until then) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D154853: [clangd][c++20]Consider the constraint of a constrained auto in FindTarget.

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:581 + +[[Fooable]] auto i = 42; + )cpp"; nridge wrote: > sammccall wrote: > > this is going to have the same behavior on the `auto` token, right? > > > > This i

[PATCH] D154853: [clangd][c++20]Consider the constraint of a constrained auto in FindTarget.

nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:581 + +[[Fooable]] auto i = 42; + )cpp"; sammccall wrote: > this is going to have the same behavior on the `auto` token, right? > > This is my main practical co

[PATCH] D154853: [clangd][c++20]Consider the constraint of a constrained auto in FindTarget.

sammccall added a comment. Sorry about the delay here. Making the whole AutoTypeLoc resolve to the concept doesn't seem right - the `auto` part does not refer to the concept, and in principle refers to another type entirely. Really I think there should be a child node representing just the con

[PATCH] D154853: [clangd][c++20]Consider the constraint of a constrained auto in FindTarget.

massberg updated this revision to Diff 538952. massberg added a comment. clang-format code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154853/new/ https://reviews.llvm.org/D154853 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-ex

[PATCH] D154853: [clangd][c++20]Consider the constraint of a constrained auto in FindTarget.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Thi