This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9ca395b5ade1: [clang][AST] Propagate the contains-errors bit
to DeclRefExpr from VarDecl's… (authored by hokein).
Changed prior to commit:
https:/
hokein updated this revision to Diff 538929.
hokein marked 2 inline comments as done.
hokein added a comment.
address comments and add release note.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154861/new/
https://reviews.llvm.org/D154861
Files:
shafik added inline comments.
Comment at: clang/lib/AST/ComputeDependence.cpp:461
/// based on the declaration being referenced.
ExprDependence clang::computeDependence(DeclRefExpr *E, const ASTContext &Ctx)
{
auto Deps = ExprDependence::None;
`computeDepen
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, but please be sure to add a release note (and the newline at the end of
the test file). Thank you for the fix!
Comment at: clang/test/AST/ast-dump-recove
hokein created this revision.
hokein added reviewers: aaron.ballman, shafik, sammccall.
Herald added a project: All.
hokein requested review of this revision.
Herald added a project: clang.
Similar to the https://reviews.llvm.org/D86048 (it only sets the bit for C++
code), we propagate the contain
