[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

sylvestre.ledru added a comment. In D154869#4652703 , @DanielCChen wrote: > Sorry about the breakage This is why we have CI ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.ll

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

DanielCChen added a comment. Sorry about the breakage and thanks to @DavidSpickett for revert it. We will reconsider all the input and bring it back as a PR in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.l

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

sylvestre.ledru added a comment. Thanks for the revert! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.llvm.org/D154869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

DavidSpickett added a comment. I've reverted this https://github.com/llvm/llvm-project/commit/ffc67bb3602a6a9a4f886af362e1f2d7c9821570 as Linaro's flang and clang bots are red all over and we're also in an upgrade period for the build server (https://discourse.llvm.org/t/llvm-zorg-migration-to

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

mizvekov added a comment. This broke a buildbot, as a user reported on discord: https://buildkite.com/llvm-project/github-pull-requests/builds/5171#018aec0c-75ba-431a-a5c8-6a5cba51de28 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ http

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

pscoro added a comment. In D154869#4652224 , @sylvestre.ledru wrote: > With this patch, it started to fail with: > It would be nice to have a better error message suggesting what to do > > -- Performing Test HAVE_DECL_STRERROR_S > -- Performing Test

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

sylvestre.ledru added a comment. With this patch, it started to fail with: It would be nice to have a better error message suggesting what to do -- Performing Test HAVE_DECL_STRERROR_S -- Performing Test HAVE_DECL_STRERROR_S - Failed CMake Error at /build/source/flang-rt/unittests/CMakeList

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6403287eff71: [Flang] [FlangRT] Introduce FlangRT project as solut

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

DanielCChen accepted this revision. DanielCChen added a comment. @all It seems all the comments are addressed or explained. If there is no objection from the reviewers, we would like to land this patch in Phabricator before the deadline. I will approve it now, but @madanial please wait until th

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

madanial added a comment. In D154869#4628847 , @efriedma wrote: > Maybe split the changes to reformat the unittests into a separate patch? > > Otherwise, I'm happy with the current state of this patch, but probably > someone more active in flang should a

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

madanial added inline comments. Comment at: runtimes/CMakeLists.txt:20 +set(RUNTIMES_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) + ldionne wrote: > This shouldn't be necessary, CMake already creates a `Project_SOURCE_DIR` > variable for each declared `project()` I

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

h-vetinari added a comment. Any update on this patchset? With the migration away from phabricator, it'd be good to get this in soonish (otherwise it'll need to be moved to github). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

ldionne added inline comments. Comment at: runtimes/CMakeLists.txt:20 +set(RUNTIMES_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) + This shouldn't be necessary, CMake already creates a `Project_SOURCE_DIR` variable for each declared `project()` IIRC. Repository:

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

efriedma added a comment. Maybe split the changes to reformat the unittests into a separate patch? Otherwise, I'm happy with the current state of this patch, but probably someone more active in flang should approve. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

madanial added a comment. Pinging for review. I will be taking over this patch from Paul, but Paul will still be around to answer any questions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.llvm.org/D154869 __

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

pscoro added inline comments. Comment at: flang-rt/unittests/FortranEvaluate/testing.h:1 +#ifndef FORTRAN_EVALUATE_TESTING_H_ +#define FORTRAN_EVALUATE_TESTING_H_ klausler wrote: > Why was this file (and testing.cpp) added instead of being moved, like other > fi

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

klausler added inline comments. Comment at: flang-rt/unittests/FortranEvaluate/testing.h:1 +#ifndef FORTRAN_EVALUATE_TESTING_H_ +#define FORTRAN_EVALUATE_TESTING_H_ Why was this file (and testing.cpp) added instead of being moved, like other files were? Why are

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

pscoro added a comment. Ping I will not be able to help out with flang (for a while) after the end of August so the sooner I can get this reviewed the smoother the landing process will be for myself and the community. So I would appreciate if I could get reviewers looking at this as soon as po