Re: [PATCH] D15509: Suggest missing 'template' for dependent member templates

2016-04-15 Thread Richard Smith via cfe-commits
rsmith requested changes to this revision. This revision now requires changes to proceed. Comment at: lib/Parse/ParseTemplate.cpp:1233-1240 @@ -1240,1 +1232,10 @@ + + SuppressAllDiagnostics S(Diags); + GreaterThanIsOperatorScope G(GreaterThanIsOperator, false); + TemplateArgLis

Re: [PATCH] D15509: Suggest missing 'template' for dependent member templates

2016-04-15 Thread Nikola Smiljanić via cfe-commits
nikola added a comment. Would anyone be kind enough to review this? http://reviews.llvm.org/D15509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15509: Suggest missing 'template' for dependent member templates

2016-02-15 Thread Nikola Smiljanić via cfe-commits
nikola added a comment. Ping. http://reviews.llvm.org/D15509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15509: Suggest missing 'template' for dependent member templates

2015-12-14 Thread Nikola Smiljanić via cfe-commits
nikola created this revision. nikola added a reviewer: rsmith. nikola added a subscriber: cfe-commits. Current diagnostic says "expected expression" or "reference to non-static member function must be called". This should fix PR13566 and PR18995 http://reviews.llvm.org/D15509 Files: lib/Parse