This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG96e50797d6ea: [clangd] Fix the range for include reference
to itself. (authored by VitaNuo).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
VitaNuo marked 2 inline comments as done.
VitaNuo added a comment.
Thanks for the comments!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155215/new/
https://reviews.llvm.org/D155215
___
cfe-commits
VitaNuo updated this revision to Diff 540385.
VitaNuo added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155215/new/
https://reviews.llvm.org/D155215
Files:
clang-tools-extra/clangd/IncludeCleaner.cpp
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/IncludeCleaner.h:87
+
+// Returns the range starting at '#' and ending at EOL. Escaped newlines are
not
+// handled.
VitaNuo updated this revision to Diff 540321.
VitaNuo added a comment.
Re-use the logic from include cleaner in clangd.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155215/new/
https://reviews.llvm.org/D155215
Files:
VitaNuo created this revision.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
VitaNuo requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Repository:
rG LLVM Github Monorepo
