This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG57ca62d5d35a: [clang][Interp] Implement __builtin_copysign
(authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D155368?vs=541
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155368/new/
https://reviews.llvm.org/D155368
___
cfe-commits mailing list
tbaeder updated this revision to Diff 541325.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155368/new/
https://reviews.llvm.org/D155368
Files:
clang/lib/AST/Interp/InterpBuiltin.cpp
Index: clang/lib/AST/Interp/InterpBuiltin.cpp
===
tbaeder added a comment.
I can add some basic tests for `__builtin_copysign` here, but there are test
added in https://reviews.llvm.org/D155369 as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155368/new/
https://reviews.llvm.org/D155368
__
aaron.ballman added a comment.
Missing test coverage for copysign.
Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:141
+
+static bool interp__builtin_fmin(InterpState &S, CodePtr OpPC,
+ const InterpFrame *Frame, const Function *F) {
-
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/
