This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc4a5b5849767: [Clang][RISCV] Guard RVV intrinsics types that
is not available when ELEN 64 (authored by eopXD).
Repository:
rG LLVM Github
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155414/new/
https://reviews.llvm.org/D155414
eopXD updated this revision to Diff 541636.
eopXD marked an inline comment as done.
eopXD added a comment.
Address comment from Craig.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155414/new/
https://reviews.llvm.org/D155414
Files:
craig.topper added inline comments.
Comment at: clang/lib/Sema/SemaChecking.cpp:5336
+ // least zve64x
+ if ((Ty->isRVVType(/* Bitwidth */ 64, /* IsFloat */ false) &&
+ !TI.hasFeature("zve64x")) ||
Can we do
```
if ((Ty->isRVVType(/* Bitwidth */ 64, /*
eopXD updated this revision to Diff 541100.
eopXD added a comment.
Rebase to latest main
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155414/new/
https://reviews.llvm.org/D155414
Files:
clang/include/clang/AST/Type.h
eopXD created this revision.
eopXD added reviewers: aaron.ballman, craig.topper.
Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck,
luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei,
PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,
