[PATCH] D155574: [clang][ASTImporter] Fix import of recursive field initializer.

2023-07-27 Thread Balázs Kéri via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf4438385d4d9: [clang][ASTImporter] Fix import of recursive field initializer. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155574/ne

[PATCH] D155574: [clang][ASTImporter] Fix import of recursive field initializer.

2023-07-26 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 544371. balazske added a comment. Added check for duplicate import of initializer. Added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155574/new/ https://reviews.llvm.org/D155574 Files: clang/l

[PATCH] D155574: [clang][ASTImporter] Fix import of recursive field initializer.

2023-07-26 Thread Ding Fei via Phabricator via cfe-commits
danix800 added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3936-3937 +return std::move(Err); + if (ToInitializer) +ToField->setInClassInitializer(ToInitializer); return ToField; balazske wrote: > danix800 wrote: > > Initializer could in

[PATCH] D155574: [clang][ASTImporter] Fix import of recursive field initializer.

2023-07-26 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3936-3937 +return std::move(Err); + if (ToInitializer) +ToField->setInClassInitializer(ToInitializer); return ToField; danix800 wrote: > Initializer could indirectly depends on

[PATCH] D155574: [clang][ASTImporter] Fix import of recursive field initializer.

2023-07-25 Thread Ding Fei via Phabricator via cfe-commits
danix800 added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3936-3937 +return std::move(Err); + if (ToInitializer) +ToField->setInClassInitializer(ToInitializer); return ToField; Initializer could indirectly depends on this field and set

[PATCH] D155574: [clang][ASTImporter] Fix import of recursive field initializer.

2023-07-20 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 542383. balazske added a comment. using clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155574/new/ https://reviews.llvm.org/D155574 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/AST

[PATCH] D155574: [clang][ASTImporter] Fix import of recursive field initializer.

2023-07-18 Thread Balázs Benics via Phabricator via cfe-commits
steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155574/new/ https://reviews.llvm.org/D155574 ___

[PATCH] D155574: [clang][ASTImporter] Fix import of recursive field initializer.

2023-07-18 Thread Balázs Kéri via Phabricator via cfe-commits
balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang. Herald added a subs