[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d4e14c76b4e: [clang][OpenMP] Add interop support for multiple depend clauses (authored by mhalk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155692/new/

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155692/new/ https://reviews.llvm.org/D155692 ___

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

mhalk updated this revision to Diff 542130. mhalk added a comment. Fixed `HasNowaitClause` always set to zero Renamed corresponding variable to `DependenceList`, to better reflect its meaning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155692/ne

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

mhalk added a comment. As far as I can tell, no. This *should* already be covered by Ndeps + DepList from `__tgt_interop_init`'s signature: __tgt_interop_init(ident_t *LocRef, kmp_int32 Gtid, [...], kmp_int32 Ndeps, kmp_depend_info_t *DepList, kmp_int32 HaveNowait) Which is very similar t

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

tianshilei1992 added a comment. In D155692#4515364 , @mhalk wrote: > In D155692#4515265 , > @tianshilei1992 wrote: > >> We don't need to update the interface function to indicate how many deps we >> have? > > Wh

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

mhalk added a comment. In D155692#4515265 , @tianshilei1992 wrote: > We don't need to update the interface function to indicate how many deps we > have? Which //interface function// exactly? `__tgt_interop_[init|use|destroy]`? Repository: rG LLVM G

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

tianshilei1992 added a comment. We don't need to update the interface function to indicate how many deps we have? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155692/new/ https://reviews.llvm.org/D155692 _

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

mhalk updated this revision to Diff 542032. mhalk added a comment. Rebase + removed `RunCleanupsScope` for preparation w.r.t. D137607 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155692/new/ https://reviews.llvm

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

mhalk added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6986 +DependenceAddress = DependenciesArray.getPointer(); +CodeGenFunction::RunCleanupsScope LocalScope(*this); } ABataev wrote: > mhalk wrote: > > Not sure if this is useful h

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6986 +DependenceAddress = DependenciesArray.getPointer(); +CodeGenFunction::RunCleanupsScope LocalScope(*this); } mhalk wrote: > Not sure if this is useful here. > Saw this `

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

mhalk added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6986 +DependenceAddress = DependenciesArray.getPointer(); +CodeGenFunction::RunCleanupsScope LocalScope(*this); } Not sure if this is useful here. Saw this `RunCleanupsScope` i

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

mhalk updated this revision to Diff 541942. mhalk added a comment. Fix accidental remove of `assert(...)`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155692/new/ https://reviews.llvm.org/D155692 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp cla

[PATCH] D155692: [clang][OpenMP] Add interop support for multiple depend clauses

mhalk created this revision. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. mhalk requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. This patch removes t