[PATCH] D155992: [clangd] Use xxh3_64bits for background index file digests

This revision was automatically updated to reflect the committed changes. Closed by commit rG16d79d26b3b6: [clangd] Use xxh3_64bits for background index file digests (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155992/new/

[PATCH] D155992: [clangd] Use xxh3_64bits for background index file digests

MaskRay added a comment. In D155992#4527081 , @kadircet wrote: > thanks for doing this! > > as Sam pointed out this will result in invalidation of all the index shards, > but that's not something new. we already don't clean up non-relevant index >

[PATCH] D155992: [clangd] Use xxh3_64bits for background index file digests

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Agree - LGTM but please land once the branch `release/17.x` exists. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155992/new/

[PATCH] D155992: [clangd] Use xxh3_64bits for background index file digests

kadircet added a comment. thanks for doing this! as Sam pointed out this will result in invalidation of all the index shards, but that's not something new. we already don't clean up non-relevant index shards when people delete sources over time and rely on people having new checkouts or

[PATCH] D155992: [clangd] Use xxh3_64bits for background index file digests

MaskRay updated this revision to Diff 543200. MaskRay added a comment. Herald added a subscriber: wenlei. bump version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155992/new/ https://reviews.llvm.org/D155992 Files:

[PATCH] D155992: [clangd] Use xxh3_64bits for background index file digests

sammccall added a comment. These hashes are used in the filenames of index shards, and in the metadata describing dependencies between shards. So this is an incompatible change to indexing format, you also need to increment `constexpr static uint32_t Version` in Serialization.cpp:460. (I

[PATCH] D155992: [clangd] Use xxh3_64bits for background index file digests

MaskRay created this revision. MaskRay added reviewers: kadircet, sammccall. Herald added a subscriber: arphaman. Herald added a project: All. MaskRay requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang-tools-extra. Many sources