probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
Huh. It looks like someone else removed that stuff from lang-std.cpp recently.
I'd have thought that would cause a failure on our bot, but whatever.
LGTM.
CHANGES SINCE LAST ACTION
Sunil_Srivastava updated this revision to Diff 543088.
Sunil_Srivastava added a comment.
Deleted Sie specific test, now that the behavior is same as the default.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155998/new/
https://reviews.llvm.org/D155998
Files:
probinson added a comment.
(Also remove the now-incorrect comment from lang-std.cpp)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155998/new/
https://reviews.llvm.org/D155998
___
cfe-commits mailing
probinson added a comment.
The value of a separate test for PS4/PS5 is questionable, now that it's the
same as the general Clang default.
Probably better to delete `lang-std-sie.cpp` and remove the UNSUPPORTED from
`lang-std.cpp` ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST