[PATCH] D156178: [HLSL] add pow library function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf5137e984a6: [HLSL] add pow library function (authored by bob80905). Changed prior to commit: https://reviews.llvm.org/D156178?vs=548296&id=54832

[PATCH] D156178: [HLSL] add pow library function

bob80905 updated this revision to Diff 548296. bob80905 added a comment. - clang format pow.hlsl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156178/new/ https://reviews.llvm.org/D156178 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/t

[PATCH] D156178: [HLSL] add pow library function

bogner added a comment. In D156178#4530161 , @bogner wrote: > Looking at > https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-pow, > it seems a bit underspecified, but do we need to worry about differences > between that spec

[PATCH] D156178: [HLSL] add pow library function

bob80905 added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/pow.hlsl:10 +// CHECK: call half @llvm.pow.f16( +// NO_HALF: define noundef float @"?test_pow_half@@YA$halff@$halff@0@Z"( +// NO_HALF: call float @llvm.pow.f32( bogner wrote: > Why check

[PATCH] D156178: [HLSL] add pow library function

bob80905 updated this revision to Diff 543757. bob80905 added a comment. - add func name to checks, clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156178/new/ https://reviews.llvm.org/D156178 Files: clang/lib/Headers/hlsl/hlsl_intrin

[PATCH] D156178: [HLSL] add pow library function

bogner added a comment. Looking at https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-pow, it seems a bit underspecified, but do we need to worry about differences between that spec and IEEE behaviour here? For example, it says there that `x<0, y=any -> NaN`, but we'

[PATCH] D156178: [HLSL] add pow library function

bob80905 added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/pow.hlsl:6 +// RUN: dxil-pc-shadermodel6.3-library %s -emit-llvm -disable-llvm-passes \ +// RUN: -D__HLSL_ENABLE_16_BIT -o - | FileCheck %s --check-prefix=NO_HALF + beanz wrote: > Doe

[PATCH] D156178: [HLSL] add pow library function

beanz added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/pow.hlsl:6 +// RUN: dxil-pc-shadermodel6.3-library %s -emit-llvm -disable-llvm-passes \ +// RUN: -D__HLSL_ENABLE_16_BIT -o - | FileCheck %s --check-prefix=NO_HALF + Does this need to set

[PATCH] D156178: [HLSL] add pow library function

bob80905 updated this revision to Diff 543731. bob80905 added a comment. - add eof newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156178/new/ https://reviews.llvm.org/D156178 Files: clang/lib/Headers/hlsl/hlsl_intrinsics.h clang/test/Co

[PATCH] D156178: [HLSL] add pow library function

bob80905 updated this revision to Diff 543730. bob80905 added a comment. - remove non-floating-point func decls from header file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156178/new/ https://reviews.llvm.org/D156178 Files: clang/lib/Headers/

[PATCH] D156178: [HLSL] add pow library function

bob80905 created this revision. bob80905 added reviewers: python3kgae, beanz. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change exposes the pow library fu