This revision was automatically updated to reflect the committed changes.
Closed by commit rG6b4de7b1c71b: [clang][deps] add support for dependency
scanning with cc1 command line (authored by cpsughrue, committed by
jansvoboda11).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
cpsughrue updated this revision to Diff 546861.
cpsughrue added a comment.
Fixing failed test on Windows CI
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156234/new/
https://reviews.llvm.org/D156234
Files:
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp
jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.
LGTM after Windows CI gets fixed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156234/new/
https://reviews.llvm.org/D156234
cpsughrue updated this revision to Diff 546182.
cpsughrue added a comment.
Update llvm-lit test to use split-file
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156234/new/
https://reviews.llvm.org/D156234
Files:
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp
cpsughrue added inline comments.
Comment at:
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:482
+ bool Success = false;
+ if (FinalCommandLine[1] == "-cc1") {
+Success = createAndRunToolInvocation(FinalCommandLine, Action, *FileMgr,
jansvoboda11 added inline comments.
Comment at:
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:482
+ bool Success = false;
+ if (FinalCommandLine[1] == "-cc1") {
+Success = createAndRunToolInvocation(FinalCommandLine, Action, *FileMgr,
Bigcheese added inline comments.
Comment at:
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:482
+ bool Success = false;
+ if (FinalCommandLine[1] == "-cc1") {
+Success = createAndRunToolInvocation(FinalCommandLine, Action, *FileMgr,
cpsughrue added inline comments.
Comment at:
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:482
+ bool Success = false;
+ if (FinalCommandLine[1] == "-cc1") {
+Success = createAndRunToolInvocation(FinalCommandLine, Action, *FileMgr,
Is
cpsughrue updated this revision to Diff 545910.
cpsughrue retitled this revision from "[clang][deps] provide support for cc1
command line scanning" to "[clang][deps] add support for dependency scanning
with cc1 command line".
cpsughrue edited the summary of this revision.
cpsughrue added a