[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG235390d930be: [NFC] Avoid potential dereferencing of nullptr. (authored by schittir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156274/new/

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

schittir added a comment. In D156274#4545581 , @schittir wrote: > Test failure seems unrelated to change. Driver/fsanitize.c lit test passes in > my local testing. Restarting build. The build is now green. Landing the patch. CHANGES SINCE LAST ACTION

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

schittir added a comment. In D156274#4544804 , @aaron.ballman wrote: > LGTM! Are you planning to work on the ObjC issues separately? (Not suggesting > you have to! But if you don't intend to, can you file an issue in GitHub so > we don't lose track of

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

schittir added a comment. Test failure seems unrelated to change. Driver/fsanitize.c lit test passes in my local testing. Restarting build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156274/new/ https://reviews.llvm.org/D156274 ___

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Are you planning to work on the ObjC issues separately? (Not suggesting you have to! But if you don't intend to, can you file an issue in GitHub so we don't lose track of

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

schittir updated this revision to Diff 545410. schittir added a comment. Remove changes in CGObjCMac.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156274/new/ https://reviews.llvm.org/D156274 Files: clang/lib/AST/ItaniumMangle.cpp clang/lib/Sema/SemaCodeComplete.cpp Index:

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

aaron.ballman added a comment. In D156274#4539522 , @schittir wrote: > Thank you for the review, @aaron.ballman and @efriedma > Do you recommend any changes here? The changes to SemaCodeComplete.cpp and ItaniumMangle.cpp are good, the changes in

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

schittir added a comment. Thank you for the review, @aaron.ballman and @efriedma Do you recommend any changes here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156274/new/ https://reviews.llvm.org/D156274

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

aaron.ballman added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:1659 mangleCXXDtorType(Dtor_Complete); +assert(ND); writeAbiTags(ND, AdditionalAbiTags); efriedma wrote: > aaron.ballman wrote: > > This seems incorrect -- if the

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

efriedma added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:1659 mangleCXXDtorType(Dtor_Complete); +assert(ND); writeAbiTags(ND, AdditionalAbiTags); aaron.ballman wrote: > This seems incorrect -- if the declaration name is a

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

aaron.ballman added subscribers: efriedma, rjmccall. aaron.ballman added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:1659 mangleCXXDtorType(Dtor_Complete); +assert(ND); writeAbiTags(ND, AdditionalAbiTags); This seems incorrect --

[PATCH] D156274: [NFC] Avoid potential dereferencing of nullptr.

schittir created this revision. schittir added reviewers: aaron.ballman, tahonermann, erichkeane. Herald added a project: All. schittir requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. Repository: rG LLVM Github Monorepo