[PATCH] D156330: [hexagon] restore library path arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96832a6bf7e0: [hexagon] restore library path arguments (authored by androm3da). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156330: [hexagon] restore library path arguments

bcain updated this revision to Diff 544533. bcain added a comment. Too hasty w/the last update - forgot to remove the `-###`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156330/new/ https://reviews.llvm.org/D156330 Files:

[PATCH] D156330: [hexagon] restore library path arguments

bcain updated this revision to Diff 544532. bcain added a comment. I misunderstood the previous suggestion about `-fdriver-only -Werror -v` and thought I needed to separate the test into two invocations. Combined these back into a single RUN now. Repository: rG LLVM Github Monorepo

[PATCH] D156330: [hexagon] restore library path arguments

MaskRay added a comment. In D156330#4536827 , @bcain wrote: > Fixed target: `--target=hexagon-unknown-linux` was not correct for testing > this bug, it should have been `--target=hexagon-unknown-linux-musl`. > > Used `-fdriver-only -Werror` as suggested

[PATCH] D156330: [hexagon] restore library path arguments

bcain updated this revision to Diff 544527. bcain added a comment. Fixed target: `--target=hexagon-unknown-linux` was not correct for testing this bug, it should have been `--target=hexagon-unknown-linux-musl`. Used `-fdriver-only -Werror` as suggested but it did require separating the tests.

[PATCH] D156330: [hexagon] restore library path arguments

bcain added a comment. In D156330#4535974 , @MaskRay wrote: > Tip: use `%clang -fdriver-only -Werror -v` to test that a command produces no > warning or error and has an exit code of 0. Without it your > `Args.ClaimAllArgs(options::OPT_L);` change is

[PATCH] D156330: [hexagon] restore library path arguments

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Tip: use `%clang -fdriver-only -Werror -v` to test that a command produces no warning or error and has an exit code of 0. Without it your `Args.ClaimAllArgs(options::OPT_L);` change is

[PATCH] D156330: [hexagon] restore library path arguments

bcain created this revision. bcain added reviewers: sidneym, kparzysz, MaskRay. Herald added a project: All. bcain requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before applying this fix, clang would not include the specified library path