This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3c6a7b0045af: [clangd] Revert the symbol collector behavior
to old pre-include-cleaner… (authored by VitaNuo).
Repository:
rG LLVM Github
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:842
- auto [It, Inserted] = SymbolProviders.try_emplace(S.ID);
- if (Inserted) {
-auto Headers =
-include_cleaner::headersForSymbol(Sym, SM, Opts.PragmaIncludes);
-
VitaNuo updated this revision to Diff 544689.
VitaNuo marked an inline comment as done.
VitaNuo added a comment.
Address comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156403/new/
https://reviews.llvm.org/D156403
Files:
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:901
}
+if (auto StdSym = tooling::stdlib::Symbol::named(S->Scope, S->Name, Lang))
+ if
VitaNuo updated this revision to Diff 544684.
VitaNuo marked 6 inline comments as done.
VitaNuo added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156403/new/
https://reviews.llvm.org/D156403
Files:
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:841-847
auto [It, Inserted] = SymbolProviders.try_emplace(S.ID);
if (Inserted) {
auto Headers =
include_cleaner::headersForSymbol(Sym, SM, Opts.PragmaIncludes);
VitaNuo created this revision.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
VitaNuo requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Repository:
rG LLVM Github Monorepo
