[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

This revision was automatically updated to reflect the committed changes. Closed by commit rG20e01167b15a: [Clang] Produce a warning instead of an error in unevaluated strings before… (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. In D156596#4573354 , @aaron.ballman wrote: > LGTM but please wait for @hubert.reinterpretcast to confirm the new tests > cover what he was looking for. LGTM;

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM but please wait for @hubert.reinterpretcast to confirm the new tests cover what he was looking for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

cor3ntin updated this revision to Diff 548503. cor3ntin added a comment. Add C tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156596/new/ https://reviews.llvm.org/D156596 Files: clang/include/clang/Basic/DiagnosticLexKinds.td

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

hubert.reinterpretcast added a comment. In D156596#4558097 , @cor3ntin wrote: > Note: we are waiting for feedback from @hubert.reinterpretcast's people > before progressing this. The "full" build hit some (unrelated) snags, but the initial results look

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

cor3ntin added a comment. Note: we are waiting for feedback from @hubert.reinterpretcast's people before progressing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156596/new/ https://reviews.llvm.org/D156596

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:290 + "encoding prefix '%0' on an unevaluated string literal has no effect" + "%select{| and is incompatible with c++2c}1">, + InGroup>; cor3ntin wrote: >

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:290 + "encoding prefix '%0' on an unevaluated string literal has no effect" + "%select{| and is incompatible with c++2c}1">, + InGroup>; hubert.reinterpretcast wrote:

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:290 + "encoding prefix '%0' on an unevaluated string literal has no effect" + "%select{| and is incompatible with c++2c}1">, + InGroup>; aaron.ballman

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:290 + "encoding prefix '%0' on an unevaluated string literal has no effect" + "%select{| and is incompatible with c++2c}1">, + InGroup>; hubert.reinterpretcast

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:290 + "encoding prefix '%0' on an unevaluated string literal has no effect" + "%select{| and is incompatible with c++2c}1">, + InGroup>; I am not seeing

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

hubert.reinterpretcast added a comment. In D156596#4546742 , @aaron.ballman wrote: > If so, I'd like @hubert.reinterpretcast to mention if this works for his > needs. We are putting together a build for the (known) affected groups. I will report back

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

cor3ntin added inline comments. Comment at: clang/test/CXX/dcl.dcl/dcl.link/p2.cpp:11-14 +extern u8"C" {} // expected-warning {{encoding prefix 'u8' on an unevaluated string literal has no effect and is incompatible with c++2c}} +extern L"C" {} // expected-warning {{encoding

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

hubert.reinterpretcast added inline comments. Comment at: clang/test/SemaCXX/static-assert.cpp:44-45 +static_assert(false, L"\x1ff"// expected-warning {{encoding prefix 'L' on an unevaluated string literal has no effect and is incompatible with c++2c}} \ +

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

aaron.ballman added a comment. In D156596#4546787 , @cor3ntin wrote: > Oups, sorry, the context is this PR https://reviews.llvm.org/D105759#4543246 I kind of figured. :-) But we want the context in the patch summary since that's what typically makes it

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

cor3ntin added a comment. Oups, sorry, the context is this PR https://reviews.llvm.org/D105759#4543246 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156596/new/ https://reviews.llvm.org/D156596 ___

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

aaron.ballman added a subscriber: hubert.reinterpretcast. aaron.ballman added a comment. Please add more details to the patch summary explaining why you're making these changes. Also, I assume this is to be backported to Clang 17? If so, I'd like @hubert.reinterpretcast to mention if this works

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

cor3ntin updated this revision to Diff 545374. cor3ntin added a comment. Format + Add FixIt tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156596/new/ https://reviews.llvm.org/D156596 Files: clang/include/clang/Basic/DiagnosticLexKinds.td

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D156596 Files: